Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nf-test for local subworkflow ARRIBA_WORKFLOW #578

Merged
merged 12 commits into from
Dec 11, 2024
Merged

Add nf-test for local subworkflow ARRIBA_WORKFLOW #578

merged 12 commits into from
Dec 11, 2024

Conversation

alanmmobbs93
Copy link

PR checklist

Closes rnafusion #530

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnafusion branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit d9cedb1

+| ✅ 222 tests passed       |+
#| ❔   2 tests were ignored |#

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-11 19:01:14

@alanmmobbs93 alanmmobbs93 marked this pull request as draft December 9, 2024 13:11
@alanmmobbs93 alanmmobbs93 marked this pull request as ready for review December 9, 2024 19:14
@alanmmobbs93
Copy link
Author

I left some comments that I think can be improved in further iterations, what do you think?

atrigila
atrigila approved these changes Dec 11, 2024
View reviewed changes
Copy link

@atrigila atrigila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@alanmmobbs93 alanmmobbs93 merged commit 077eb17 into nf-core:dev Dec 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrigila atrigila atrigila approved these changes

@nschcolnicov nschcolnicov Awaiting requested review from nschcolnicov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanmmobbs93 @atrigila @nschcolnicov